Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update c-ares to 1.29.0 #53155

Merged
merged 2 commits into from
Jun 2, 2024
Merged

deps: update c-ares to 1.29.0 #53155

merged 2 commits into from
Jun 2, 2024

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of c-ares to 1.29.0.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label May 26, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/net
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run. labels May 26, 2024
@lpinca lpinca force-pushed the actions/tools-update-c-ares branch from 6fb3d30 to 8e2ec74 Compare May 26, 2024 07:31
lpinca
lpinca reviewed May 26, 2024
View reviewed changes
deps/cares/src/lib/thirdparty/apple/dnsinfo.h
@@ -0,0 +1,128 @@
/*
Copy link
Member

@lpinca lpinca May 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently not included in the release tarball, see c-ares/c-ares#763.

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label May 26, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 26, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/59496/

@nodejs-github-bot

This comment was marked as duplicate.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/59549/

@lpinca lpinca force-pushed the actions/tools-update-c-ares branch from 8e2ec74 to 5c37cba Compare June 1, 2024 18:30
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 1, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 1, 2024
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/59605/

@lpinca lpinca added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 2, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 2, 2024
@nodejs-github-bot nodejs-github-bot merged commit 41d90aa into main Jun 2, 2024
56 checks passed
@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-c-ares branch June 2, 2024 05:30
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 41d90aa

targos pushed a commit that referenced this pull request Jun 3, 2024
@nodejs-github-bot @targos
deps: update c-ares to 1.29.0
257004c 
PR-URL: #53155
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jun 7, 2024
Merged
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@nodejs-github-bot @eliphazbouye
deps: update c-ares to 1.29.0
fdb3a5b 
PR-URL: nodejs#53155
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@nodejs-github-bot @bmeck
deps: update c-ares to 1.29.0
778f633 
PR-URL: nodejs#53155
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@zcbenz zcbenz mentioned this pull request Jul 2, 2024
Merged
@targos targos added lts-watch-v18.x PRs that may need to be released in v18.x. lts-watch-v20.x PRs that may need to be released in v20.x labels Jul 5, 2024
@targos targos mentioned this pull request Jul 5, 2024
Open
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@nodejs-github-bot @marco-ippolito
deps: update c-ares to 1.29.0
d37c1eb 
PR-URL: #53155
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@nodejs-github-bot @marco-ippolito
deps: update c-ares to 1.29.0
7a126e8 
PR-URL: #53155
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Jul 19, 2024
Merged
codebytere added a commit to electron/electron that referenced this pull request Jul 25, 2024
@codebytere
deps: update c-ares to 1.29.0
2b571bc 
nodejs/node#53155
codebytere added a commit to electron/electron that referenced this pull request Jul 26, 2024
@codebytere
deps: update c-ares to 1.29.0
217bcd4 
nodejs/node#53155
jkleinsc pushed a commit to electron/electron that referenced this pull request Jul 26, 2024
@electron-roller @codebytere @VerteDinde
chore: bump node to v20.16.0 (main) (#43029)
b3d52c0 
* chore: bump node in DEPS to v20.16.0

* test: skip unstable shadow realm gc tests

nodejs/node#52855

* test: extend env for `test-node-output-errors`

nodejs/node#53535

* src: fix typo in env.cc

nodejs/node#53418

* src: reset `process.versions` during pre-execution

nodejs/node#53444

* chore: fixup patch indices

* src,permission: --allow-wasi & prevent WASI exec

nodejs/node#53124

* tls: use SSL_get_peer_tmp_key

nodejs/node#53366

* deps: update c-ares to 1.29.0

nodejs/node#53155

* src: account for OpenSSL unexpected version

* crypto: fix propagation of "memory limit exceeded"

nodejs/node#53300

* process: add process.getBuiltinModule(id)

nodejs/node#52762

* windows 32bit: config change callback needs to be stdcall

c-ares/c-ares@8f265c9

* fix: building with UNICODE

c-ares/c-ares#802

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
Co-authored-by: Keeley Hammond <[email protected]>
@targos targos removed the lts-watch-v20.x PRs that may need to be released in v20.x label Sep 30, 2024
aduh95 pushed a commit that referenced this pull request Nov 2, 2024
@nodejs-github-bot @aduh95
deps: update c-ares to 1.29.0
6ba8bc0 
PR-URL: #53155
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@aduh95 aduh95 added backported-to-v18.x PRs backported to the v18.x-staging branch. and removed lts-watch-v18.x PRs that may need to be released in v18.x. labels Nov 2, 2024
@aduh95 aduh95 mentioned this pull request Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
backported-to-v18.x PRs backported to the v18.x-staging branch. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nodejs-github-bot @lpinca @targos @RafaelGSS @marco-ippolito @VoltrexKeyva @aduh95